Run as Trusted Installer context menu

[sendersu]

@HarrySpoofer
thanks for nice piece of work!

If you don't mind I"d provide some small feedback:

1) I'd do case insensitive comparison inside the GetProcessIdByName() routine
-> if (pe.szExeFile == processName)

2) compiler is unhappy on setting signed int to unsided dword;
warning C4245: 'initializing': conversion from 'int' to 'DWORD', signed/unsigned mismatch

do you know if Windows has got some define for wrong pid values?
eg smth like INVALID_HANDLE_VALUE

3) be honest, did you leave an Easter Egg in one routine?

kudos!

[Kerlingen]

The code is pretty much identical to the https://github.com/lilkui/runasti repository.

The only difference is that somebody refactored everything to camel case (e.g. "get_process_id_by_name(const string process_name)" becomes "GetProcessIdByName(wstring processName)").

The code in the repository already has some of the bugs fixed!

[HarrySpoofer]

Originally Posted by sendersu

@HarrySpoofer
thanks for nice piece of work!

If you don't mind I"d provide some small feedback:

1) I'd do case insensitive comparison inside the GetProcessIdByName() routine
-> if (pe.szExeFile == processName)

2) compiler is unhappy on setting signed int to unsided dword;
warning C4245: 'initializing': conversion from 'int' to 'DWORD', signed/unsigned mismatch

do you know if Windows has got some define for wrong pid values?
eg smth like INVALID_HANDLE_VALUE

3) be honest, did you leave an Easter Egg in one routine?

kudos!

Thank for the feedback.
I made the changes you suggested and updated the attachment and the link.

BTW: I did not put an Easter egg in it, I added new icons, though.

[sendersu]

Originally Posted by HarrySpoofer

Thank for the feedback.
I made the changes you suggested and updated the attachment and the link.

BTW: I did not put an Easter egg in it, I added new icons, though.

I was under impression this line is it -

>> wctomb_s(&mbCharLen, &buff[0], 42, wc);

[HarrySpoofer]

Originally Posted by sendersu

I was under impression this line is it -
>> wctomb_s(&mbCharLen, &buff[0], 42, wc);

Well it is the answer to the ultimate question of life, the universe, and everything but I should have put MB_LEN_MAX in there.

Originally Posted by sendersu

one more feedback:
is it OK to delegate memory zero-ing to compiler?

Yes, it is a matter of habit

Originally Posted by sendersu

one more question:
it is really require d to enable this priv lvl?
>EnablePrivilege(SE_DEBUG_NAME);

Yes, this is the reason why you need to be an `Administrator` to become the `Trusted Installer`